Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac: prefer newest Xcode when searching using mdfind #18737

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Nov 8, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We're currently returning the first match for com.apple.dt.Xcode,
which could be any version if a user has multiple installed.

Instead, let's try to find the newest if all our results have an
Info.plist that we can interrogate for the version.

Maybe resolves #18736?

For reference, on my system, before this change:

❯ brew ruby -e 'puts MacOS.app_with_bundle_id("com.apple.dt.Xcode")'
/Applications/Xcode-14.3.1.app

after this change:

❯ brew ruby -e 'puts MacOS.app_with_bundle_id("com.apple.dt.Xcode")'
/Applications/Xcode.app

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, people have complained about this a lot for ages. Looks good as-is but may want a tweak for readability and/or correctness.

Library/Homebrew/os/mac.rb Outdated Show resolved Hide resolved
We're currently returning the first match for `com.apple.dt.Xcode`,
which could be any version if a user has multiple installed.

Instead, let's try to find the newest if all our results have an
`Info.plist` that we can interrogate for the version.

Maybe resolves #18736?
@carlocab carlocab merged commit 025d1c7 into master Nov 8, 2024
28 checks passed
@carlocab carlocab deleted the prefer-newest-xcode branch November 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants