Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL #18749

Merged
merged 1 commit into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. Support setting GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL

    Our autobump workflow sets the author and committer to the user who
    triggered the workflow, defaulting to @BrewTestBot for scheduled runs.
    
    This can be confusing for maintainers when GitHub shows up as
    "Unverified" because the commit is signed with @BrewTestBot's key.[^1]
    
    Let's fix that by configuring our autobump workflow to always commit as
    @BrewTestBot, so that the committer matches the GPG signature. To do
    that, we need to add support for setting `GIT_COMMITTER_NAME` and
    `GIT_COMMITTER_EMAIL`.
    
    [^1]: See, for example, Homebrew/homebrew-core#197234.
    carlocab committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1fbe436 View commit details
    Browse the repository at this point in the history