Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actionlint: suppress zizmor's exit code #18753

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Nov 12, 2024

This uses || true to suppress zizmor's exit code, which is being surfaced as a failure due to the workflow wide set -e default.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @woodruffw!

@MikeMcQuaid MikeMcQuaid merged commit acb3675 into master Nov 12, 2024
31 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ww/zizmor-suppress-exit branch November 12, 2024 08:37
bevanjkay added a commit to bevanjkay/.github that referenced this pull request Nov 12, 2024
bevanjkay added a commit to Homebrew/homebrew-core that referenced this pull request Nov 12, 2024
MikeMcQuaid pushed a commit to Homebrew/.github that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants