Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptable-Casks: remove outdated info #18760

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Acceptable-Casks: remove outdated info #18760

merged 1 commit into from
Nov 13, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Let's replace this with something consistent that doesn't need to be updated every year. If a cask can't be installed on the current major macOS version, we shouldn't accept it.

@p-linnane p-linnane added the documentation Documentation changes label Nov 12, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @p-linnane!

@MikeMcQuaid MikeMcQuaid merged commit b421c2f into master Nov 13, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rm-outdated-info branch November 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants