os/mac/diagnostic: fix OpenCore check #18764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongRuoyu
approved these changes
Nov 13, 2024
Taken from Neofetch[^1]. Fixes #18763. [^1]: https://github.com/dylanaraps/neofetch/blob/ccd5d9f52609bbdcd5d8fa78c4fdb0f12954125f/neofetch#L1260-L1261
carlocab
force-pushed
the
fix-opencore-check
branch
from
1761e14
to
b7764b5
Compare
carlocab
commented
Nov 13, 2024
Comment on lines
+134
to
+135
| loaded_kexts = Utils.safe_popen_read("/usr/bin/kmutil", "showloaded") | ||
| return if loaded_kexts.exclude?("FakeSMC") && loaded_kexts.exclude?("VirtualSMC") |
There was a problem hiding this comment.
Unfortunately this check also flags VMs, so doesn't really work 😢
https://github.com/Homebrew/brew/actions/runs/11816737888/job/32920685713?pr=18764#step:4:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Taken from Neofetch1.
Fixes #18763.
Footnotes
https://github.com/dylanaraps/neofetch/blob/ccd5d9f52609bbdcd5d8fa78c4fdb0f12954125f/neofetch#L1260-L1261 ↩