Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated/disabled messages to cask pages #993

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add deprecated/disabled messages to cask pages #993

merged 1 commit into from
Dec 18, 2023

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 18, 2023

Follow-up to Homebrew/brew#16292

Show a warning when casks are deprecated or disabled now.


Something interesting that I noticed (that affects both formulae and casks), the title attribute of the h2 includes the deprecation reason, but it just uses the pre-set reason instead of converting it to the actual string.

For example, take zdoom (which will soon contain deprecate! date: "2023-12-17", because: :discontinued). Right now, the title attribute is set to:

This cask has been deprecated since 2023-12-17 because it discontinued

Instead of:

This cask has been deprecated since 2023-12-17 because it is discontinued upstream

Anyway, something for another PR

@Bo98
Copy link
Member

Bo98 commented Dec 18, 2023

Yeah that issue affects formulae too.

@Rylan12 Rylan12 merged commit 250b7bd into Homebrew:master Dec 18, 2023
1 check passed
@Rylan12 Rylan12 deleted the add-deprecate-disable-to-casks branch December 18, 2023 00:31
@MikeMcQuaid
Copy link
Member

Great work thanks @Rylan12 and thanks @Bo98 for merging.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants