This repository has been archived by the owner on May 2, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use deprecate!
instead of discontinued
#18724
Merged
p-linnane
merged 60 commits into
Homebrew:master
from
Rylan12:replace-discontinued-with-deprecate
Dec 18, 2023
Merged
Use deprecate!
instead of discontinued
#18724
p-linnane
merged 60 commits into
Homebrew:master
from
Rylan12:replace-discontinued-with-deprecate
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
the
ci-syntax-only
Only run syntax checks on CI. Use only for bulk changes.
label
Dec 17, 2023
7 tasks
chenrui333
approved these changes
Dec 18, 2023
p-linnane
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Homebrew/brew#16292
Move all instances of
discontinued
in thecaveats
stanza to adeprecate!
call.For now, I've left the date for all of these as today (
2023-12-17
) because it doesn't seem to me like it will be a good use of my time to go through each and figure out an appropriate date. If that isn't the best solution, though, I'm happy to hear about alternatives.This PR was made using
brew style --fix
with Homebrew/brew#16351 checked out, and then the non-autocorrectable (when thecaveats
stanza includes more than justdiscontinued
) offenses were handled manually.Note: this PR cannot be merged until a new Homebrew/brew tag (4.2.0) is made.