Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deprecate! instead of discontinued #162720

Merged
merged 236 commits into from
Dec 18, 2023
Merged

Use deprecate! instead of discontinued #162720

merged 236 commits into from
Dec 18, 2023

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 17, 2023 •
edited
Loading

See Homebrew/brew#16292

Move all instances of discontinued in the caveats stanza to a deprecate! call.

For now, I've left the date for all of these as today1 (2023-12-17) because it doesn't seem to me like it will be a good use of my time to go through each and figure out an appropriate date. If that isn't the best solution, though, I'm happy to hear about alternatives.

This PR was made using brew style --fix with Homebrew/brew#16351 checked out, and then the non-autocorrectable (when the caveats stanza includes more than just discontinued) offenses were handled manually.

Note: this PR cannot be merged until a new Homebrew/brew tag (4.2.0) is made.

Footnotes

  1. Except for dozer which I set to 2023-11-26 because there was a comment ↩

@Rylan12 Rylan12 added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Dec 17, 2023
@Rylan12 Rylan12 mentioned this pull request Dec 17, 2023
Merged
7 tasks
@Rylan12
360safe: use deprecate! instead of discontinued
6c6f233
@Rylan12
a-slower-speed-of-light: use deprecate! instead of discontinued
50f0ba1
@Rylan12
actual: use deprecate! instead of discontinued
d6dd1e7
@Rylan12
adoptopenjdk: use deprecate! instead of discontinued
9c15eec
@Rylan12
agenda: use deprecate! instead of discontinued
a3e2fce
@Rylan12
airunlock: use deprecate! instead of discontinued
f44017d
@Rylan12
altdeploy: use deprecate! instead of discontinued
35bb708
@Rylan12
alva: use deprecate! instead of discontinued
ca599c1
@Rylan12
amm: use deprecate! instead of discontinued
c7a4ce2
@Rylan12
amorphousdiskmark: use deprecate! instead of discontinued
662b424
@Rylan12
android-messages: use deprecate! instead of discontinued
828cefd
@Rylan12
android-sdk: use deprecate! instead of discontinued
ed3b12c
@Rylan12
anka-build-cloud-controller-and-registry: use deprecate! instead of…
d7dd6f6 
… `discontinued`
@Rylan12
ansible-dk: use deprecate! instead of discontinued
446d0db
@Rylan12
appcode: use deprecate! instead of discontinued
5a0b443
@Rylan12
appdelete: use deprecate! instead of discontinued
31794f5
@Rylan12
appium: use deprecate! instead of discontinued
a93f1fe
@Rylan12
apple-events: use deprecate! instead of discontinued
16685fe
@Rylan12
arduino: use deprecate! instead of discontinued
531ac13
@Rylan12
aria2gui: use deprecate! instead of discontinued
131ba10
@Rylan12
ark-desktop-wallet: use deprecate! instead of discontinued
fa6044e
@Rylan12
atom: use deprecate! instead of discontinued
ac63fae
@Rylan12
avocode: use deprecate! instead of discontinued
d993590
@Rylan12
aware: use deprecate! instead of discontinued
e13d2ac
@Rylan12
banshee: use deprecate! instead of discontinued
618d974
@Rylan12
battery-report: use deprecate! instead of discontinued
825949b
@Rylan12
beaker-browser: use deprecate! instead of discontinued
6224613
@Rylan12
videostream: use deprecate! instead of discontinued
e964265
@Rylan12
vlc-webplugin: use deprecate! instead of discontinued
c04134e
@Rylan12
vpn-enabler: use deprecate! instead of discontinued
b5a75bf
@Rylan12
webcamoid: use deprecate! instead of discontinued
21ab9c9
@Rylan12
webpack-dashboard: use deprecate! instead of discontinued
a4a1515
@Rylan12
webrecorder-player: use deprecate! instead of discontinued
9abb2f4
@Rylan12
wey: use deprecate! instead of discontinued
950554a
@Rylan12
wjoy: use deprecate! instead of discontinued
53e58c9
@Rylan12
wkhtmltopdf: use deprecate! instead of discontinued
fc826df
@Rylan12
wonderfultools-screensaver: use deprecate! instead of discontinued
7a68f6a
@Rylan12
writefull: use deprecate! instead of discontinued
81f6534
@Rylan12
x-mirage: use deprecate! instead of discontinued
8b6763d
@Rylan12
xamarin-studio: use deprecate! instead of discontinued
f47ccf7
@Rylan12
xamarin-workbooks: use deprecate! instead of discontinued
1b2d28c
@Rylan12
xampp-vm: use deprecate! instead of discontinued
d508f6f
@Rylan12
xtorrent: use deprecate! instead of discontinued
78910ad
@Rylan12
yo: use deprecate! instead of discontinued
05ce313
@Rylan12
youtrack-workflow: use deprecate! instead of discontinued
c5cd9fe
@Rylan12
yu-writer: use deprecate! instead of discontinued
c5f578a
@Rylan12
zazu: use deprecate! instead of discontinued
41221fb
@Rylan12
zdoom: use deprecate! instead of discontinued
5cb47da
@Rylan12
zecwallet-lite: use deprecate! instead of discontinued
6eda0fe
@Rylan12
zeebe-modeler: use deprecate! instead of discontinued
18df44b
@Rylan12
zsa-wally: use deprecate! instead of discontinued
f21905e
@SMillerDev
Copy link
Member

Great work @Rylan12, although it's a shame I get to tick something off my list that I didn't do.

@chenrui333
Copy link
Member

Awesome job! Merging!

@chenrui333 chenrui333 merged commit b8ef1bc into Homebrew:master Dec 18, 2023
6 checks passed
@Rylan12 Rylan12 deleted the replace-discontinued-with-deprecate branch December 19, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rylan12 @SMillerDev @chenrui333 @alexeyignatiev @bevanjkay @BrewTestBot