Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidekick 0.5.3 (new formula) #191345

Merged
merged 2 commits into from
Sep 21, 2024
Merged

sidekick 0.5.3 (new formula) #191345

merged 2 commits into from
Sep 21, 2024

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Suggesting sidekick-cli for the name, because there is an overlap with an existing cask sidekick.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Sep 20, 2024
@chenrui333
Copy link
Member

Suggesting sidekick-cli for the name, because there is an overlap with an existing cask sidekick.

I dont feel like we need to do it because of the name overlapping?

Formula/s/sidekick-cli.rb Outdated Show resolved Hide resolved
@bevanjkay
Copy link
Member Author

I dont feel like we need to do it because of the name overlapping?

@chenrui333 Was based on the comment here - Homebrew/brew#16309 (comment) - which isn't really documented. But I'm not too concerned either way.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Sep 21, 2024
@bevanjkay bevanjkay force-pushed the sidekick branch 4 times, most recently from 2f772b6 to ff675fa Compare September 21, 2024 00:18
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request autobump labels Sep 21, 2024
@chenrui333
Copy link
Member

I dont feel like we need to do it because of the name overlapping?

@chenrui333 Was based on the comment here - Homebrew/brew#16309 (comment) - which isn't really documented. But I'm not too concerned either way.

I see, sounds good then :)

Formula/s/sidekick-cli.rb Outdated Show resolved Hide resolved
@bevanjkay bevanjkay changed the title sidekick-cli 0.5.3 (new formula) sidekick 0.5.3 (new formula) Sep 21, 2024
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 21, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2024
Merged via the queue into master with commit 2b71c22 Sep 21, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the sidekick branch September 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants