Fix bad livecheck block url symbols

[samford]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

The livecheck blocks in this PR use url :url but :url should only be used in casks and this should be url :stable instead.

---

For what it's worth, I'm creating a RuboCop for this, so bad symbol references should be surfaced in the future. I'm currently working on refactoring the livecheck RuboCop setup, so the cops will also apply to livecheck blocks in resources and casks. It's most of the way done (it works for formulae/resources and most casks) but I have to account for some unusual cask setups before I create a PR.

[carlocab]

Seems weird that these passed the brew livecheck test run by test-bot anyway.

[samford]

Seems weird that these passed the brew livecheck test run by test-bot anyway.

@carlocab livecheck doesn't error if a livecheck block uses a symbol argument that doesn't correspond to a checkable URL. The formulae in this PR are using a cask symbol but this can also occur if a livecheck block uses a symbol for an optional URL like head but the referenced URL is later removed.

When a bad symbol is provided, likecheck ignores it and goes through the checkable URLS in the formula (the default behavior). The stable URL is checked first, so these end up working as expected merely by chance.

It only becomes apparent if the check fails or you use --debug and livecheck has to iterate through more than one checkable URL before reaching one that works. I'll see about adding an error in livecheck to catch this at runtime as well, as it can lead to unexpected behavior.

[carlocab]

When a bad symbol is provided, likecheck ignores it and goes through the checkable URLS in the formula (the default behavior). The stable URL is checked first, so these end up working as expected merely by chance.

That doesn't seem like the right behaviour.

[samford]

That doesn't seem like the right behaviour.

I agree. I should have been clear that it's not intentional behavior and only happens because we forgot to account for this error condition. I'll have a brew PR up once I finish testing (edit: Homebrew/brew#18622).