Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with rubocop 1.68.0 #196534

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Make compatible with rubocop 1.68.0 #196534

merged 2 commits into from
Nov 4, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Nov 3, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See Homebrew/brew#18682

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 3, 2024
dduugg
dduugg commented Nov 3, 2024
View reviewed changes
Formula/p/portaudio.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 3, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 3, 2024
@samford samford mentioned this pull request Nov 3, 2024
Draft
6 tasks
@Bo98 Bo98 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 3, 2024
Bo98
Bo98 requested changes Nov 3, 2024
View reviewed changes
Formula/g/gbdfed.rb Outdated Show resolved Hide resolved
Formula/l/[email protected] Outdated Show resolved Hide resolved
Formula/r/regldg.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 4, 2024
Merged via the queue into Homebrew:master with commit 7c518d7 Nov 4, 2024
18 checks passed
@dduugg dduugg deleted the rubocop-1.68.0 branch November 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@samford samford samford approved these changes

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dduugg @Bo98 @samford @carlocab @BrewTestBot