-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use ubuntu-latest #196774
base: master
Are you sure you want to change the base?
ci: use ubuntu-latest #196774
Conversation
Align CI setup with what has been done in Homebrew/brew#18704 Use ubuntu-latest when the ubuntu version does not matter. ubunut-latest is equivalent to 22.04 right now so this does not change anything Our ubuntu 22.04 docker image is still used (this has not been modified)
Moving to draft, I realised there is some other code here that hard-codes the runner name: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/dispatch-build-bottle.rb#L68 We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic). |
Anything that's strictly Homebrew/core specific should generally live in Homebrew/core (like However |
Makes sense, thanks for the explanation. |
Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubuntu-latest is equivalent to 22.04 right now so this does not change anything
Our ubuntu 22.04 docker image is still used (this has not been modified)
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?