Remove bottle cache hard linking #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
force-pushed
the
no-more-hardlinks
branch
from
b974848
to
2e35180
Compare
|
Thanks Bo! I've always wondered what this bit of code was really for. |
|
Fine with me. This optimisation was when our workers weren't ephemeral, we kept the cache between runs and the disk usage was excessive. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is way too fragile and has broken multiple times before (it's why we have
/github/homemanually set as the working directory in a few places), including from changes like Homebrew/brew#16245. It relies far too much on brew internals and we forgot to even update when switching to GitHub Packages until two years later. I'm not entirely sure how anyone even noticed in the end. It also has never supported manifest linking.I'm not sure if it's even necessary anymore. The formulae intentionally stay installed so when would we be fetching it again? I'd like to try without this and see what breaks. If nothing: great. If there is something: I'd like to see if there's a better way to fix it as it might mean something is getting fetched unnecessarily.
The cleanup side of it was very outdated as well and wasn't working.