Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear id's importing a new test, check for null #2257

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

stalep
Copy link
Member

@stalep stalep commented Feb 5, 2025

Fixes #2249

Clears existing id's if we're importing a new test. Also check for null on the id field that caused the import issue.

@lampajr lampajr changed the title clear id's importing a new test, check for null. fixes #2249 Clear id's importing a new test, check for null Feb 12, 2025
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lampajr lampajr merged commit 5d05e47 into Hyperfoil:master Feb 12, 2025
2 checks passed
@zakkak
Copy link
Contributor

zakkak commented Feb 13, 2025

Can we also get a documentation update reflecting this change and documenting how to duplicate tests using export/import? Thanks

@lampajr
Copy link
Member

lampajr commented Feb 13, 2025

Can we also get a documentation update reflecting this change and documenting how to duplicate tests using export/import? Thanks

Hi @zakkak, thanks for the suggestion and I fully agree.

I created this #2263 to track the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a test with missingDataRules fails
3 participants