Use Lazy Loaders #1536
Merged
Use Lazy Loaders #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafnapension
force-pushed
the
lazy_loadHF
branch
9 times, most recently
from
c8dbded to
4cf6a69
Compare
dafnapension
changed the title
dafnapension
force-pushed
the
lazy_loadHF
branch
4 times, most recently
from
20834fa to
78d0927
Compare
elronbandel
changed the title
dafnapension
force-pushed
the
lazy_loadHF
branch
3 times, most recently
from
e00617f to
134dd22
Compare
Signed-off-by: dafnapension <[email protected]>
…ing (that is dome mocking anyhow) and not evaluating (of the mocked results). add trust_remote also to load_dataset_builder Signed-off-by: dafnapension <[email protected]>
Signed-off-by: dafnapension <[email protected]>
… increase loader cache Signed-off-by: dafnapension <[email protected]>
Signed-off-by: dafnapension <[email protected]>
Signed-off-by: dafnapension <[email protected]>
dafnapension
force-pushed
the
lazy_loadHF
branch
2 times, most recently
from
016faa4 to
a4121c7
Compare
Signed-off-by: elronbandel <[email protected]>
…oading logic Signed-off-by: elronbandel <[email protected]>
…on yielded instances Signed-off-by: elronbandel <[email protected]>
… handling Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
…essary cache checks Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
…les method for improved streaming support Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
…ceptions Signed-off-by: elronbandel <[email protected]>
…ndling Signed-off-by: elronbandel <[email protected]>
elronbandel
changed the title
oktie
pushed a commit
that referenced
this pull request
Feb 11, 2025
* try lazy loadHF first Signed-off-by: dafnapension <[email protected]> * reduce benchmark profiling to generating the dataset only. Not inferring (that is dome mocking anyhow) and not evaluating (of the mocked results). add trust_remote also to load_dataset_builder Signed-off-by: dafnapension <[email protected]> * try procrastination for load csv too Signed-off-by: dafnapension <[email protected]> * added split cache for the generators, and log limit once per data and increase loader cache Signed-off-by: dafnapension <[email protected]> * make sklearn loader too - a lazy loader Signed-off-by: dafnapension <[email protected]> * adjust to new readers for csv Signed-off-by: dafnapension <[email protected]> * Enhance LoadHF class to support optional splits and improve dataset loading logic Signed-off-by: elronbandel <[email protected]> * Refactor LoadHF class to improve dataset loading and implement limit on yielded instances Signed-off-by: elronbandel <[email protected]> * Refactor LoadHF class to streamline dataset loading and enhance split handling Signed-off-by: elronbandel <[email protected]> * Remove unused import and update line number in secrets baseline Signed-off-by: elronbandel <[email protected]> * Refactor load_data method to simplify error handling and remove unnecessary cache checks Signed-off-by: elronbandel <[email protected]> * Merge origin/main Signed-off-by: elronbandel <[email protected]> * Refactor loaders to implement LazyLoader class and update load_iterables method for improved streaming support Signed-off-by: elronbandel <[email protected]> * Update exception handling in test_failed_load_csv to catch general exceptions Signed-off-by: elronbandel <[email protected]> * Refactor LoadHF class to streamline data loading and enhance error handling Signed-off-by: elronbandel <[email protected]> --------- Signed-off-by: dafnapension <[email protected]> Signed-off-by: elronbandel <[email protected]> Co-authored-by: Elron Bandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And not just in order to learn the split names therefrom (at the beginning of Benchmark, for example).
Also, avoid loading splits that are ignored altogether (like stream "test" in src/unitxt/catalog/splitters/small_no_test.json)