Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor bug when only space id is provided for WML inference #1583

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

tsinggggg
Copy link
Collaborator

WML inference is expected to support either 'WML_SPACE_ID' or 'WML_PROJECT_ID' specified, however currently the code does not handle the case where only space id is specified.

@tsinggggg
Copy link
Collaborator Author

Hi @elronbandel , would you please review this minor fix? Thank you!

Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@elronbandel elronbandel merged commit ed773e9 into IBM:main Feb 9, 2025
8 of 19 checks passed
oktie pushed a commit that referenced this pull request Feb 11, 2025
fix: wml inference with space id only

Signed-off-by: Cheng Qian <[email protected]>
Co-authored-by: Cheng Qian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants