On Windows, don't create C:\Program Files\Icinga2\var during MSI build #10137
Conversation
Al2Klimov
added
bug
I'm not sure what this is trying to say? Is this good? Is it bad? Does it miss a negation? Anyway, doesn't that imply that all of these variables are set to broken paths on Windows in general as it should always be |
| install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ICINGA2_FULL_DATADIR}/api/zones-stage\")") | ||
| install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ICINGA2_FULL_DATADIR}/certs\")") | ||
| install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ICINGA2_FULL_DATADIR}/certificate-requests\")") | ||
| endif() |
There was a problem hiding this comment.
misses any dirs listed in files changed here
I'm not sure what this is trying to say? Is this good? Is it bad? Does it miss a negation?
It means that I've "commented out" the certs dir here via NOT WIN32, but this didn't break my MSI. I.e. it still installs a certs dir where expected. That implies...
Anyway, doesn't that imply that all of these variables are set to broken paths on Windows in general as it should always be
C:\ProgramData\Icinga2\var, notC:\Program Files\Icinga2\var?
... that they're not just broken on Windows, they're pointless.
Al2Klimov
added
the
consider backporting
Test IIOn two independent machines w/o Icinga 2 installed, my non-admin could build this branch: $env:BITS = 64
$env:CMAKE_BUILD_TYPE = "RelWithDebInfo"
& .\tools\win32\load-vsenv.ps1
powershell.exe .\tools\win32\configure.ps1
& powershell.exe .\tools\win32\build.ps1
& powershell.exe .\tools\win32\test.ps1👍 |
Test
https://git.icinga.com/packaging/windows-icinga2/-/jobs/580745 neither created it in the build env, nor the MSI, installed on a separate VM, misses any dirs listed in files changed here. 👍