Prepare for QUnit 3.0 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c4f2feb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Krinkle
force-pushed
the
patch-1
branch
2 times, most recently
from
d11d8a0 to
c4f2feb
Compare
Tweak a few selectors so that the theme is compatible with QUnit 3.0 (currently in alpha). Selectors based on docs at https://qunitjs.com/browser/#theme-api
|
Thanks for making the changes here. Nice to see the QUnit out of the box experience improving too. Just want to acknowledge already I've seen your work. Haven't had much time, but hoping to take a look in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak a few selectors so that the theme is compatible with QUnit 3.0 (currently in alpha).
Reference:
#qunit-tests lito#qunit-tests > liso that the grey background won't start applying to assertions. Previously, upstream set its white background via#qunit-tests li li.passwhich was stronger. QUnit 3.0.0-alpha.2 sets this on.qunit-assert-list .passinstead.#qunit-tests > liand#qunit-tests > li.{pass,fail}elsewhere too for consistency with the above and with (new) documentation at https://qunitjs.com/browser/#theme-api..qunit-sourceselector, as that seems to be enough on both QUnit 2 and QUnit 3..qunit-assert-listselector, idem.#qunit-tests .qunit-assert-list .passinstead of#qunit-tests li li.pass. In the future,.qunit-assert-list .passshould suffice but for now we need the ID in order for the theme to remain effective in QUnit 2 as well.#qunit-userAgentoverride only in QUnit 2. In 3.0, the default might suite you better? (Text shadow was removed in HTML Reporter: QUnit 3.0 theme structure and layout qunitjs/qunit#1774).#qunit-modulefilter-search-container:afteroverride only in QUnit 2. In 3.0, the positioning logic doesn't work right (icon shifted down). This could be fixed by settingmin-heightinstead ofheight. But, given the icon was upstreamed in HTML Reporter: QUnit 3.0 theme structure and layout qunitjs/qunit#1774, the default would achieve the same effect.