Fix a bug in the huggingface model #125
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was fine-tuning the model, the bug happened. The file
finetune/data_mix.py
, line 137, inget_item
. The dictionary sample has the keyimage
. But in the huggingface model, for example, the fileinternlm-xcomposer-vl-7b/modeling_InternLM_XComposer.py
, line 381, inforward
.has_img = 'images' in samples.keys()
will never have the key namedimages
. So we should change it tohas_img = 'image' in samples.keys()
.After change: