fix(html): Reduce calls to unescape_characters which is slow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unescape_characters` method is slow, so the places it is called have been reduced. Ideally it's performance would be improved, but the html module is in the process of being completely rewritten so this is just a stop-gap.
James-LG
commented
Sep 2, 2024
| @@ -141,12 +143,20 @@ pub struct HtmlText { | |||
| impl HtmlText { | |||
| /// Creates a new [HtmlText] from the given string. | |||
| pub fn from_str(value: &str) -> HtmlText { | |||
| let text = unescape_characters(value); | |||
There was a problem hiding this comment.
unescape_characters used to be called when creating a new HtmlText. Now it is only called when getting the display text for a given HtmlText, so if that HtmlText never needs to display its text, the slow method will not be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unescape_charactersmethod is slow, so the places it is called have been reduced.Ideally it's performance would be improved, but the html module is in the process of being completely rewritten (#51) so this is just a stop-gap.