Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Money and Currency SPI for Bitcoin #4

Open
msgilligan opened this issue Jan 29, 2015 · 4 comments
Open

Implement Money and Currency SPI for Bitcoin #4

msgilligan opened this issue Jan 29, 2015 · 4 comments

Comments

@msgilligan
Copy link
Member

Is there an existing project to do this? If not, can we start one here?

@msgilligan
Copy link
Member Author

Is see there is example code for a BitcoinProvider in the JavaMoney User Guide Does that code live in a repository anywhere?

@keilw
Copy link
Member

keilw commented Jan 29, 2015

I don't think so, since the User Guide provides examples of how it may be used. Some parts of "Shelter" especially those related to defunct providers like Mt.Gox were initially contributed by JUG Chennai, mainly Raj who since also joined the EG on behalf of his JUG. I improved those after adding them to the Shelter e.g. some hard-coded references to bypass proxy, etc. that made no sense. However, as these used an outdated provider the API and RI evolved a bit at the same time, so some of these practices probably should live in the Shelter but nobody found time to "adopt" them there so far.
You'd be more than welcome to suggest a concrete SPI implementation there.

@msgilligan
Copy link
Member Author

PR #7 is my attempt at a port of the BitcoinProvider from the User's Guide to the current API/SPI. I wrote some tests and they do pass, but I'm new to the SPI and not very confident I did everything correctly.

@msgilligan msgilligan assigned msgilligan and keilw and unassigned msgilligan and keilw Feb 6, 2015
@msgilligan
Copy link
Member Author

Playing around with "Assignee" setting. It seems only one assignee is allowed. I'm going to contribute to this one but am definitely looking for help and guidance from the Moneta designer/developers.

@msgilligan msgilligan removed their assignment Feb 6, 2015
@keilw keilw added ready and removed in progress labels Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants