Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar edit — no change in content. #45

Closed
wants to merge 4 commits into from
Closed

Minor grammar edit — no change in content. #45

wants to merge 4 commits into from

Conversation

msgilligan
Copy link
Member

No description provided.

@msgilligan
Copy link
Member Author

@atsticks @keilw Did you guys notice this minor pull request?

@keilw
Copy link
Member

keilw commented Jan 28, 2015

Yes, but it must not be automatically merged, the API should only have EG Members as authors. Via Patch/Diff somebody from the EG should be able to apply, but we can't just merge it;-)

@msgilligan
Copy link
Member Author

I see. I'd say this is more editing than authoring, but I understand the situation. Just thought it might have been missed over the holidays.

So, you would like additional pull requests if I find other issues?

@keilw
Copy link
Member

keilw commented Jan 28, 2015

At least an issue, but if you find a concrete change, that is fine. Where the diff/patch can be applied manually, it certainly helps.

@msgilligan
Copy link
Member Author

Nice work on the Spec, by the way. I've been reviewing it for possible use in some Bitcoin-related projects.

@keilw
Copy link
Member

keilw commented Jan 28, 2015

Sounds great, please have a look at https://github.com/JavaMoney/javamoney-shelter/tree/master/digital-currency/bitcoin
That started with MtGox, more work to do as that exchange no longer exists, but it shows some nice patterns on how to use it.

Unlike the API or RI/TCK you'd be more then welcome to contribute there or other projects.

@msgilligan
Copy link
Member Author

Thanks! My main interests at this time are:

  1. Creating an adapter between JavaMoney and bitcoinj for representing BTC amounts. See Google groups thread.
  2. Creating JVM classes for Omni Protocol that can represent BTC and Omni Protocol based currencies. See Number of coins class OmniLayer/OmniJ#30.

I guess that might mean implementing the SPI. I'll definitely check out the "Shelter" project.

@keilw
Copy link
Member

keilw commented Jan 29, 2015

Love to hear your thoughts or input. There pull-requests are welcome and easy to merge. For those who are interested "adopting" the Shelter projects, we also have a special team. Have a look, and if there's anything to pull, we'd see it.

@msgilligan
Copy link
Member Author

OK, I created an issue over on "Shelter" for making a Bitcoin SPI, we can move this new discussion over there: JavaMoney/javamoney-shelter#4

@keilw
Copy link
Member

keilw commented Feb 12, 2015

OK, it neither could nor should be merged here any more, applied those paragraphs that are still there manually.

@keilw keilw closed this Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants