Skip to content

Commit

Permalink
ci: Fix the udp_test: it should never have worked
Browse files Browse the repository at this point in the history
Our echo-server didn't close the connection once it was done echoing, so
readers would never know they reached the end.
I guess this might've worked in the past because of a finalizer that
closed the connection when it was garbage collected
  • Loading branch information
Jille committed Aug 17, 2024
1 parent f70e652 commit 38aaf9d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions client/connectivity/udptransport/udp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ func handleEchoConnection(t *testing.T, c net.Conn) {
if err != nil {
t.Errorf("Fatal error occurred in echo server: %v", err)
}
if err := c.Close(); err != nil {
t.Errorf("Echo server failed to close: %v", err)
}
}

func sender(c net.Conn, buf []byte) error {
Expand Down

0 comments on commit 38aaf9d

Please sign in to comment.