Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error if compression of coredumps fails #20

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

IanButterworth
Copy link
Member

Doesn't fix the bug that causes JuliaCI/julia-buildkite#421 but makes it not fail the job, as that's quite disruptive.

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the current situation (lots of red) is not ideal.

So we probably need to do this as a short-term bandaid.

Can you add a comment in the shell script, linking to the issue (JuliaCI/julia-buildkite#421)?

@DilumAluthge
Copy link
Member

I think we should merge this for now, to reduce some of the red.

We can always revert this in the future once we have diagnosed and fixed the underlying bug.

@IanButterworth IanButterworth merged commit b6acb49 into main Jan 30, 2025
1 check passed
@IanButterworth IanButterworth deleted the ib/dont_error_cleanup branch January 30, 2025 21:19
@IanButterworth
Copy link
Member Author

IanButterworth commented Jan 30, 2025

Does the master version of this get used or do we need to bump something?

@DilumAluthge
Copy link
Member

I'm guessing from https://github.com/JuliaCI/julia-buildkite/blob/6c905bfb9349d45ea7c512837186208a832ef8b5/pipelines/main/platforms/test_linux.yml#L9 (and other files) that we need to make a new v2.x.y release, which I'm guessing will in turn be automatically picked up.

@IanButterworth
Copy link
Member Author

I've tagged v2.7 and updated the v2 tag https://github.com/JuliaCI/coreupload-buildkite-plugin/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants