Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion from AbstractArray to mxarray #229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tqml
Copy link

@tqml tqml commented Oct 24, 2024

Adds a conversion method to convert Julia abstract array to mxarray to avoid having them treated as structs in MATLAB.

Example:

a = transpose(rand(10)) # transpose
x = mxarray(a) # x is an actual matrix in matlab, was a struct before
y = jvalue(x) # the return value is now a matrix instead of a dictionary

Related issue #196

@tqml
Copy link
Author

tqml commented Oct 25, 2024

I removed the definitions for Ranges and BitArrays since they are only be a special case of AbstractArray, would unnecessary allocate data and get copied to MATLAB anyway

Old defs:

mxarray(a::BitArray) = mxarray(convert(Array{Bool}, a))
mxarray(a::AbstractRange) = mxarray([a;])

New definition was tested with additional special matrix types such as Diagonal, transpose and LowerTriangular.

function mxarray(a::AbstractArray{T}) where {T<:MxRealNum}
    mx = mxarray(T, size(a))
    ptr = data_ptr(mx)
    na = length(a)
    dat = unsafe_wrap(Array{T}, ptr, na)
    for (i, ix) in enumerate(eachindex(a))
        dat[i] = a[ix]
    end
    return mx
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant