Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fallback for lgamma #90

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

AayushSabharwal
Copy link
Contributor

@AayushSabharwal AayushSabharwal commented Jan 27, 2025

The interpolation syntax was incorrect, and evaluated to

if lgamma !== :lgamma
    lgamma(x) = Base.lgamma(x)
end

Which threw an UndefVarError.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (291ca27) to head (d34b1d8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files           1        1           
  Lines         150      150           
=======================================
  Hits          139      139           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit e0bfd8c into JuliaMath:master Jan 31, 2025
17 checks passed
@AayushSabharwal AayushSabharwal deleted the as/lgamma branch January 31, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants