Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-retries to macOS build notarization #4892

Merged
merged 14 commits into from
Jan 2, 2025
Merged

Add auto-retries to macOS build notarization #4892

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
19ae982
Add DEBUG=electron-notarize* to build-apps
pierremtb Jan 2, 2025
b44f512
Force IS_RELEASE: true
pierremtb Jan 2, 2025
1a8ab59
Temp: Disable version setting based on tag
pierremtb Jan 2, 2025
6ff98d7
Remove deprecated notarize.teamId and add retry logic
pierremtb Jan 2, 2025
00c71a8
Revert "Remove deprecated notarize.teamId and add retry logic"
pierremtb Jan 2, 2025
41e4c36
Retry only on macOS
pierremtb Jan 2, 2025
d3f9979
Better retry logic for macOS
pierremtb Jan 2, 2025
1e58e83
Use nick-fields/retry
pierremtb Jan 2, 2025
0459467
Clean up Temp: commits for PR
pierremtb Jan 2, 2025
4e4cf03
Clean up
pierremtb Jan 2, 2025
6a27b71
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos…
github-actions[bot] Jan 2, 2025
d202b3b
Trigger CI
pierremtb Jan 2, 2025
7fef178
Merge branch 'main' into pierremtb/issue4199-improve-mac-notarization
pierremtb Jan 2, 2025
542d4c1
Merge branch 'main' into pierremtb/issue4199-improve-mac-notarization
pierremtb Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/build-apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,13 @@ jobs:
CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
run: yarn electron-builder --config --publish always
DEBUG: "electron-notarize*"
# TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
uses: nick-fields/[email protected]
with:
timeout_minutes: 10
max_attempts: 3
command: yarn electron-builder --config --publish always

- name: List artifacts in out/
run: ls -R out
Expand Down Expand Up @@ -228,7 +234,13 @@ jobs:
CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
run: yarn electron-builder --config --publish always
DEBUG: "electron-notarize*"
# TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
uses: nick-fields/[email protected]
with:
timeout_minutes: 10
max_attempts: 3
command: yarn electron-builder --config --publish always

- uses: actions/upload-artifact@v4
if: ${{ env.IS_RELEASE == 'true' }}
Expand Down
Loading