Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trim option for empty tags #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AHarman
Copy link

@AHarman AHarman commented Apr 18, 2022

Previously, this test would fail:

'test trimming on empty tag with whitespace': skeleton(trim: true, (r) ->
    equ r.sample.emptytestanother[0], '')

where "emptytestanother" looked like this:

    <emptytestanother>

    </emptytestanother>

The value was coming back as \n \n (the whitespace between the tags).

@Leonidas-from-XIV
Copy link
Owner

Can you add the test and implement the fix in the CoffeeScript source code?

@AHarman
Copy link
Author

AHarman commented Apr 19, 2022

Sorry about that! Committed the wrong files.

I've fixed that and pushed the right changes.

@a2937
Copy link

a2937 commented Sep 19, 2024

This doesn't actually pass the tests for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants