-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error if disk is full before downloading weights #1903
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR 🚀 But there is one nuance 😊 |
Thanks! Co-authored-by: Andrei-Aksionov <[email protected]>
Thanks, that's great and important point! |
RE CI failures: I actually now what happened here: the |
@Andrei-Aksionov RoPE tests should be fixed now for the latest transformer release and if tests pass on CI, this should be ready to merge. |
Ok there seem to be other issues now with the Phi model. Also unrelated to this PR. Maybe microsoft changed something. Or the transformers library changed something. |
Probably. |
Raises an error if a user attempts to download model weights that would exceed the current available free disk space. If this is run in a Studio, it additionally prompts the user to switch to a different Studio with more disk space.
This is a minor but important point as someone can easily shoot themselves in the foot by downloading things that exceed the available storage, because once it's full, the system may go in a weird state that doesn't allow deleting and restoring things.
Fixes #1841