-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update ember-cli to 3.0 (needs clean-up) #46
base: master
Are you sure you want to change the base?
Conversation
Fixed unused import to appease eslint .travis.yml * Deleted commented-out ember-try scenarios (since releases older than 2.11 not available via npm) * Fixed typo in link
@chilicoder I ended up spending a little more time playing with this (for practice / out of curiousity) than I expected. I updated ember-cli to 3.0 and ran some codemods to get things closer to current conventions. The tests are running & passing again, but there're still some things you'll want to fix aside from general clean-up & rebasing:
|
@jacobq awesome! Great job! Thank you! I will move bootstrap to npm in separate branch. @zigahertz can you review this PR, please? |
@jacobq - beautiful work, thanks so much! I notice the "WIP" tag - is there anything left that you are wanting to work on here before merging? |
@zigahertz I left this marked as WIP because I considered it a spike left for someone else to "land". I recommended some next steps in my previous comment. I don't plan to do any more work with this, so feel free to take them or leave them (it's your project), but if it were my project I'd want to do some clean-up first and probably re-base/squash some those commits. |
Thanks @jacobq! Really appreciate your hard work and suggestions for what to do next. I am one of the collaboraters and I do not own this proejct. I don't have the bandwidth to take this on for the foreseeable future, and I know there are some folks needing this update. I will ask to see if someone else is up for finishing this. |
This is a test PR just to try TravisCI builds while troubleshooting PR #45