Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update ember-cli to 3.0 (needs clean-up) #46

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

jacobq
Copy link

@jacobq jacobq commented Feb 28, 2018

This is a test PR just to try TravisCI builds while troubleshooting PR #45

@jacobq
Copy link
Author

jacobq commented Feb 28, 2018

@chilicoder I ended up spending a little more time playing with this (for practice / out of curiousity) than I expected. I updated ember-cli to 3.0 and ran some codemods to get things closer to current conventions. The tests are running & passing again, but there're still some things you'll want to fix aside from general clean-up & rebasing:

  • Would be good to eliminate bower.json by bringing in bootstrap through npm (if it's needed at all)
  • Would be good to eliminate jQuery using built-in APIs like document.querySelectorAll
  • Setup test scenarios for older versions of ember, if needed (e.g. 2.4 & 2.8). I think they'll need to be fetched outside of npm/yarn
  • I would highly recommend using yarn.lock (in fact I was just recently burned by not doing so)

@jacobq jacobq changed the title [WIP] DO NOT MERGE [WIP] Update ember-cli to 3.0 (needs clean-up) Feb 28, 2018
@yarigpopov
Copy link

@jacobq awesome! Great job! Thank you! I will move bootstrap to npm in separate branch.

@zigahertz can you review this PR, please?

@ghost
Copy link

ghost commented Mar 5, 2018

@jacobq - beautiful work, thanks so much! I notice the "WIP" tag - is there anything left that you are wanting to work on here before merging?

@jacobq
Copy link
Author

jacobq commented Mar 5, 2018

@zigahertz I left this marked as WIP because I considered it a spike left for someone else to "land". I recommended some next steps in my previous comment. I don't plan to do any more work with this, so feel free to take them or leave them (it's your project), but if it were my project I'd want to do some clean-up first and probably re-base/squash some those commits.

@ghost
Copy link

ghost commented Jun 25, 2018

Thanks @jacobq! Really appreciate your hard work and suggestions for what to do next. I am one of the collaboraters and I do not own this proejct. I don't have the bandwidth to take this on for the foreseeable future, and I know there are some folks needing this update. I will ask to see if someone else is up for finishing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants