Skip to content

Commit

Permalink
Merge pull request #15 from warrickball/joss-tweaks-1
Browse files Browse the repository at this point in the history
Editorial tweaks to JOSS paper
  • Loading branch information
FredDeCeuster authored Dec 6, 2024
2 parents 585ad58 + 6b1b5c9 commit 86dd7c1
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 21 deletions.
22 changes: 12 additions & 10 deletions joss/paper.bib
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@ARTICLE{DeCeuster2022,
author = {{De Ceuster}, Frederik and {Ceulemans}, Thomas and {Srivastava}, Atulit and {Homan}, Ward and {Bolte}, Jan and {Yates}, Jeremy and {Decin}, Leen and {Boyle}, Peter and {Hetherington}, James},
title = "{3D Line Radiative Transfer \& Synthetic Observations with Magritte}",
title = {3D Line Radiative Transfer \& Synthetic Observations with {Magritte}},
journal = {The Journal of Open Source Software},
keywords = {radiative transfer, Python, astronomy, C++},
year = 2022,
Expand All @@ -17,24 +17,26 @@ @ARTICLE{DeCeuster2022
@ARTICLE{DeCeuster2024,
author = {{De Ceuster}, Frederik and {Ceulemans}, Thomas and {Decin}, Leen and {Danilovich}, Ta{\"\i}ssa and {Yates}, Jeremy},
title = "{Bayesian model reconstruction based on spectral line observations}",
journal = {arXiv e-prints},
journal = {The Astrophysical Journal Supplement Series},
keywords = {Astrophysics - Instrumentation and Methods for Astrophysics, Astrophysics - Solar and Stellar Astrophysics},
year = 2024,
month = feb,
eid = {arXiv:2402.18525},
pages = {arXiv:2402.18525},
doi = {10.48550/arXiv.2402.18525},
month = dec,
volume = {275},
number = {2},
eid = {44},
pages = {44},
doi = {10.3847/1538-4365/ad89a2},
archivePrefix = {arXiv},
eprint = {2402.18525},
adsurl = {https://ui.adsabs.harvard.edu/abs/2024arXiv240218525D},
adsurl = {https://ui.adsabs.harvard.edu/abs/2024ApJS..275...44D},
adsnote = {Provided by the SAO/NASA Astrophysics Data System}
}


@ARTICLE{Matsumoto2023,
author = {{Matsumoto}, Kosei and {Camps}, Peter and {Baes}, Maarten and {De Ceuster}, Frederik and {Wada}, Keiichi and {Nakagawa}, Takao and {Nagamine}, Kentaro},
title = "{Self-consistent dust and non-LTE line radiative transfer with SKIRT}",
journal = {\aap},
journal = {Astronomy & Astrophysics},
keywords = {radiative transfer, ISM: molecules, methods: numerical, infrared: ISM, Astrophysics - Astrophysics of Galaxies},
year = 2023,
month = oct,
Expand All @@ -53,7 +55,7 @@ @ARTICLE{Matsumoto2023
@ARTICLE{Coenegrachts2023,
author = {{Coenegrachts}, A. and {Danilovich}, T. and {De Ceuster}, F. and {Decin}, L.},
title = "{The unusual 3D distribution of NaCl around the asymptotic giant branch star IK Tau}",
journal = {\aap},
journal = {Astronomy & Astrophysics},
keywords = {stars: individual: IK Tau, stars: AGB and post-AGB, circumstellar matter, submillimeter: stars, Astrophysics - Solar and Stellar Astrophysics, Astrophysics - Astrophysics of Galaxies},
year = 2023,
month = oct,
Expand Down Expand Up @@ -100,7 +102,7 @@ @article{Paszke2017


@inproceedings{Paszke2019,
title = {{PyTorch}: {An} {Imperative} {Style}, {High}-{Performance} {Deep} {Learning} {Library}},
title = {{PyTorch}: An Imperative Style, High-Performance Deep Learning Library},
volume = {32},
shorttitle = {{PyTorch}},
url = {https://papers.nips.cc/paper_files/paper/2019/hash/bdbca288fee7f92f2bfa9f7012727740-Abstract.html},
Expand Down
23 changes: 12 additions & 11 deletions joss/paper.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,33 +45,34 @@ aas-journal: Astrophysical Journal Supplement Series


# Summary

A typical problem in astronomy is that, for most of our observations, we are restricted to the plane of the sky.
As a result, these observations are always mere projections containing only partial information about the observed object.
Luckily, some frequency bands of the electromagnetic spectrum are optically thin, such that we receive radiation from the entire medium along the line of sight.
This means that, at least in principle, from the observed radiation, we can extract information about the physical and chemical conditions along the entire line of sight.
This is especially the case for spectral line radiation caused by transitions between the quantized energy levels of atoms and molecules.
Rotational transition lines are particularly interesting, since they are excited in many astrophysical environments and can easily be resolved individually.
Using spectral line observations, we can infer information about physical and chemical parameters, such as abundance of certain molecules, velocity, and temperature distributions.
To facilitate this, we built a Python package, called [pomme]{.sc}, that helps users reconstruct 1D spherically symmetric or generic 3D models, based on astronomical spectral line observations.
To facilitate this, we built a Python package, called pomme, that helps users reconstruct 1D spherically symmetric or generic 3D models, based on astronomical spectral line observations.
A detailed description and validation of the methods can be found in [@DeCeuster2024].


# Statement of need
Spectral line observations are indispensible in astronomy.
Spectral line observations are indispensable in astronomy.
As a result, many line radiation transport solvers exist to solve the (forward) problem of determining what spectral line observations of a certain model would look like [@DeCeuster2022; @Matsumoto2023].
However, far fewer tools exist to efficiently solve the more pressing inverse problem of determining what model could correspond to certain observations, commonly referred to as fitting our models to observtions.
Although one can use existing forward solvers to iteratively solve the inverse problem, the resulting process is often slow, cumbersome, and leaves, much room for improvement [@Coenegrachts2023; @Danilovich2024].
Therefore, in [pomme]{.sc}, we have implemented a line radiative transfer solver (the forward problem) in the [PyTorch]{.sc} framework [@Paszke2019] to leverage the [autograd]{.sc} functionality [@Paszke2017] to efficiently fit our models to the observations (the inverse problem) in a streamlined way [@DeCeuster2024].
However, far fewer tools exist to efficiently solve the more pressing inverse problem of determining what model could correspond to certain observations, commonly referred to as fitting our models to observations.
Although one can use existing forward solvers to iteratively solve the inverse problem, the resulting process is often slow, cumbersome, and leaves much room for improvement [@Coenegrachts2023; @Danilovich2024].
Therefore, in pomme, we have implemented a line radiative transfer solver (the forward problem) in the PyTorch framework [@Paszke2019] to leverage the autograd functionality [@Paszke2017] to efficiently fit our models to the observations (the inverse problem) in a streamlined way [@DeCeuster2024].


# Example
\autoref{fig:example} shows an application of [pomme]{.sc}, where it was used to reconstruct the abundance distribution of NaCl (table salt) around the evolved star IK Tauri.
The reconstruction is based on observations of the NaCl ($J=26-25$) rotational line, taken with the Atacama Large (sub)Millimetre Array (ALMA), shown in \autoref{fig:example_obs}.
The original analysis was done by @Coenegrachts2023, and we improved their methods using [pomme]{.sc} as described in @DeCeuster2024.
\autoref{fig:example} shows an application of pomme, where it was used to reconstruct the abundance distribution of NaCl (table salt) around the evolved star IK Tauri.
The reconstruction is based on observations of the NaCl ($J=26-25$) rotational line, taken with the Atacama Large Millimeter/submillimeter Array (ALMA), shown in \autoref{fig:example_obs}.
The original analysis was done by @Coenegrachts2023, and we improved their methods using pomme as described in @DeCeuster2024.

![Reconstruction of the NaCl abundance distribution around the evolved star IK Tauri, created with [pomme]{.sc}. An interactive version of the figure is available in the [documentation](https://pomme.readthedocs.io/en/latest/_static/NaCl_reconstruction.html). \label{fig:example}](IKTau_NaCl.png)
![Reconstruction of the NaCl abundance distribution around the evolved star IK Tauri, created with pomme. An interactive version of the figure is available in the [documentation](https://pomme.readthedocs.io/en/latest/_static/NaCl_reconstruction.html). \label{fig:example}](IKTau_NaCl.png)

![NaCl ($J=26-25$) rotational line observations, taken with the Atacama Large (sub)Millimetre Array (ALMA), which is used as input in [pomme]{.sc} to create a reconstruction. \label{fig:example_obs}](IKTau_NaCl_obs.png)
![NaCl ($J=26-25$) rotational line observations, taken with the Atacama Large Millimeter/submillimeter Array (ALMA), which is used as input in pomme to create a reconstruction. \label{fig:example_obs}](IKTau_NaCl_obs.png)


# Acknowledgements
Expand All @@ -81,4 +82,4 @@ LD acknowledges support from KU Leuven C1 MAESTRO grant C16/17/007, KU Leuven C1
TD is supported in part by the Australian Research Council through a Discovery Early Career Researcher Award, number DE230100183, and by the Australian Research Council Centre of Excellence for All Sky Astrophysics in 3 Dimensions (ASTRO 3D), through project number CE170100013.


# References
# References

0 comments on commit 86dd7c1

Please sign in to comment.