Fix 6127: softlock during invalid Pointblank Shot #6496
Merged
+696
−128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were actually two issues in 6127:
This patch fixes both issues, so that only units that can make PBS attacks get the prompt, and the user can use the Skip Attacks button if they change their mind (or if an invalid unit somehow slips through and gets a PBS prompt).
Also fixes #6128, hidden units remaining hidden if they choose not to use PBS but would have been revealed, and implements fly-over side scanning for ASFs with Active Probes.
Testing:
Close #6127
Close #6128
Implements ASF errata here: https://bg.battletech.com/forums/index.php?topic=84054.0