fix: addresses the off by one issue presenting the wrong filtering re… #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sults for skill level for mass training, fixes issue MegaMek#5922
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5994 +/- ##
============================================
+ Coverage 10.29% 10.32% +0.03%
- Complexity 6108 6118 +10
============================================
Files 1038 1038
Lines 139302 139295 -7
Branches 20664 20662 -2
============================================
+ Hits 14337 14389 +52
+ Misses 123533 123466 -67
- Partials 1432 1440 +8 ☔ View full report in Codecov by Sentry. |
IllianiCBT
requested changes
Feb 6, 2025
| for (int i = SkillLevel.ULTRA_GREEN.ordinal(); i < SkillLevel.ELITE.ordinal(); i++) { | ||
| personExpModel.addElement(new PersonTypeItem(Skills.SKILL_LEVELS[i].toString(), i)); | ||
| for (int i = SkillLevel.ULTRA_GREEN.ordinal(); i <= SkillLevel.ELITE.ordinal(); i++) { | ||
| personExpModel.addElement(new PersonTypeItem(SkillLevel.parseFromInteger(i).toString(), SkillLevel.parseFromInteger(i).getAdjustedValue())); |
There was a problem hiding this comment.
We should probably be storing SkillLevel.parseFromInteger in a variable so we don't have to fetch it twice.
Something like...
final SkillLevel skillLevel = SkillLevel.parseFromInteger(i);
personExpModel.addElement(new PersonTypeItem(skillLevel.toString(), skillLevel.getAdjustedValue()));
IllianiCBT
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sults for skill level for mass training, fixes issue #5922
Second attempt here at a fix.
I assume
Elitelevel personnel should be selectable as a dropdown in the filter for mass training? Without this fix, Elite does not show up in the dropdown. This also correctly shows the right personnel given the example save provided in the referenced issue.If I'm misunderstanding something here, please correct me.