Fix lint:fix package script #5204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some developers run `yarn lint:fix` before pushing. After the ESLint 9 upgrade, however, this package script has been broken because it fixes all lint warnings in addition to errors. Since there are many, many warnings, this ends up making all kind of changes. In addition, the fixing step was happening twice, meaning that the package script was very, very slow. This commit gets this script in working order again.
mcmire
commented
Jan 27, 2025
| @@ -25,7 +25,7 @@ | |||
| "lint:dependencies": "depcheck && yarn dedupe --check", | |||
| "lint:dependencies:fix": "depcheck && yarn dedupe", | |||
| "lint:eslint": "yarn build:only-clean && yarn ts-node ./scripts/run-eslint.ts --cache", | |||
| "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix", | |||
| "lint:fix": "yarn lint:eslint --quiet --fix && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix", | |||
There was a problem hiding this comment.
--quiet hides warnings, and the combination of --quiet and --fix will only autofix errors and not warnings.
mcmire
commented
Jan 27, 2025
| @@ -44,7 +44,7 @@ main().catch((error) => { | |||
| async function main() { | |||
| const { cache, fix, quiet } = parseCommandLineArguments(); | |||
|
|
|||
| const eslint = new ESLint({ cache, fix }); | |||
There was a problem hiding this comment.
The fix option instructs lintFiles to autofix errors as it finds them. We manually call outputFixes in runESLint further down which does the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Some developers run
yarn lint:fixbefore pushing. After the ESLint 9 upgrade, however, this package script has been broken because it fixes all lint warnings in addition to errors. Since there are many, many warnings, this ends up making all kind of changes. In addition, the fixing step was happening twice, meaning that the package script was very, very slow.This commit gets this script in working order again.
References
Changelog
(N/A, developer-only change)
Checklist