feat: add new keyring type for oneKey #5216
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akaryatrh
force-pushed
the
feat/793-oneKey-dedicated-keyring
branch
from
c7dd5e2 to
4893887
Compare
Akaryatrh
force-pushed
the
feat/793-oneKey-dedicated-keyring
branch
from
4893887 to
f82c08a
Compare
7 tasks
ccharly
approved these changes
Feb 11, 2025
github-merge-queue bot
pushed a commit
to MetaMask/accounts
that referenced
this pull request
Feb 11, 2025
This PR adds support for a dedicated OneKey keyring (until now it was sharing the same keyring instance than Trezor) so it's considered as a standalone device and could get its own tag inside account list. There are two others PRs: - metamask-extension: MetaMask/metamask-extension#29999 - core (accounts and keyring controllers): MetaMask/core#5216 Fixes: MetaMask/accounts-planning#793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds support for a dedicated OneKey keyring (until now it was sharing the same keyring instance than Trezor) so it's considered as a standalone device and could get its own tag inside account list.
There are two others PRs:
References
Fixes: https://github.com/MetaMask/accounts-planning/issues/793
Changelog
@metamask/accounts-controller@metamask/keyring-controllerChecklist