Fix unmocked block tracker warning in NetworkController tests #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running one of the tests for the `destroy` method, an error from the block tracker can be observed. This error does not fail the test, but it creates noise in the output. It turns out that this happens because we are failing to mock a request in the test. This commit adds the requisite test so that the `console.error` goes away.
mcmire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When running one of the tests for NetworkController, we were seeing a warning in the test output indicating that a request from the block tracker was not properly mocked. This commit adds that mock so the warning goes away.
References
(None)
Changelog
(N/A, developer-only change)
Checklist