Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get assets list from MultichainAssetsController state #5295

Merged
merged 27 commits into from
Feb 7, 2025

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Feb 6, 2025

Explanation

We are getting the full list of assets for an account via the MultichainAssetsController state, instead of only requesting the native token.

References

Changelog

@metamask/assets-controllers

  • ADDED: Adds the ability to request for all the assets that an account can have

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@zone-live zone-live requested a review from a team as a code owner February 6, 2025 15:08
@sahar-fehri
Copy link
Contributor

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "23.0.0-preview-1adbaffc",
  "@metamask-previews/address-book-controller": "6.0.2-preview-1adbaffc",
  "@metamask-previews/announcement-controller": "7.0.2-preview-1adbaffc",
  "@metamask-previews/approval-controller": "7.1.2-preview-1adbaffc",
  "@metamask-previews/assets-controllers": "48.0.0-preview-1adbaffc",
  "@metamask-previews/base-controller": "7.1.1-preview-1adbaffc",
  "@metamask-previews/build-utils": "3.0.2-preview-1adbaffc",
  "@metamask-previews/composable-controller": "10.0.0-preview-1adbaffc",
  "@metamask-previews/controller-utils": "11.5.0-preview-1adbaffc",
  "@metamask-previews/earn-controller": "0.2.0-preview-1adbaffc",
  "@metamask-previews/ens-controller": "15.0.1-preview-1adbaffc",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-1adbaffc",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-1adbaffc",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-1adbaffc",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-1adbaffc",
  "@metamask-previews/keyring-controller": "19.0.6-preview-1adbaffc",
  "@metamask-previews/logging-controller": "6.0.3-preview-1adbaffc",
  "@metamask-previews/message-manager": "12.0.0-preview-1adbaffc",
  "@metamask-previews/multichain": "2.1.0-preview-1adbaffc",
  "@metamask-previews/multichain-transactions-controller": "0.2.0-preview-1adbaffc",
  "@metamask-previews/name-controller": "8.0.2-preview-1adbaffc",
  "@metamask-previews/network-controller": "22.2.0-preview-1adbaffc",
  "@metamask-previews/notification-services-controller": "0.20.0-preview-1adbaffc",
  "@metamask-previews/permission-controller": "11.0.5-preview-1adbaffc",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-1adbaffc",
  "@metamask-previews/phishing-controller": "12.3.1-preview-1adbaffc",
  "@metamask-previews/polling-controller": "12.0.2-preview-1adbaffc",
  "@metamask-previews/preferences-controller": "15.0.1-preview-1adbaffc",
  "@metamask-previews/profile-sync-controller": "7.0.0-preview-1adbaffc",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-1adbaffc",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-1adbaffc",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-1adbaffc",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-1adbaffc",
  "@metamask-previews/signature-controller": "23.2.0-preview-1adbaffc",
  "@metamask-previews/token-search-discovery-controller": "2.0.0-preview-1adbaffc",
  "@metamask-previews/transaction-controller": "45.0.0-preview-1adbaffc",
  "@metamask-previews/user-operation-controller": "24.0.0-preview-1adbaffc"
}

sahar-fehri
sahar-fehri previously approved these changes Feb 6, 2025
@sahar-fehri
Copy link
Contributor

I was testing a scenario where i add an account; remove it; and then add again;
I'm seeing an unexpected behavior where its failing to fetch the balance with Unknown account Error;
Will look more

@zone-live zone-live requested a review from a team as a code owner February 7, 2025 10:29
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! (so much cleanup being done here 🚀)

@ccharly ccharly merged commit e607b7f into main Feb 7, 2025
129 checks passed
@ccharly ccharly deleted the SOL-get-assets-list branch February 7, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants