RpcService: Regard node-fetch errors as retriable #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `node-fetch` internally for testing. This library produces its own error messages whenever a request cannot be initiated, so we need to account for it within the RpcService retry logic. However, we need to make sure to exclude errors from Nock so we don't get weird results in tests.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
mcmire
commented
Feb 6, 2025
| @@ -191,7 +379,7 @@ describe('RpcService', () => { | |||
| const jsonRpcRequest = { | |||
| id: 1, | |||
| jsonrpc: '2.0' as const, | |||
| method: 'eth_chainId', | |||
| method: 'eth_unknownMethod', | |||
There was a problem hiding this comment.
I discovered while making these changes that these tests were actually incorrect but were not failing. Considering that they created Nock errors I decided to fix them at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently we have tests for middleware to verify that requests get retried when certain errors are thrown. In a future commit we will replace the retry logic in these middleware with RpcService, and when this happens the aforementioned tests will break. This is because we are using Nock to force the request to throw errors, and in tests we use
node-fetchto polyfill thefetchfunction, andnode-fetcherrors are not regarded as retriable by RpcService.This commit adjusts RpcService to treat
node-fetcherrors as retriable (but making sure to exclude errors from Nock itself, since they will also be manifested asnode-fetcherrors).References
This is a prerequisite for #4991.
Changelog
(N/A; developer-only change since RpcService is still internal.)
Checklist