Add signEIP7702Authorization to KeyringController #5301
+563
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
changed the title
jeffsmale90
force-pushed
the
feat/7702-sign-authorization
branch
from
e225fe3 to
082e817
Compare
jeffsmale90
force-pushed
the
feat/7702-sign-authorization
branch
from
082e817 to
47935e0
Compare
jeffsmale90
commented
Feb 12, 2025
Comment on lines
-14
to
+15
| import SimpleKeyring from '@metamask/eth-simple-keyring/dist/simple-keyring'; | ||
| import SimpleKeyring from '@metamask/eth-simple-keyring'; |
There was a problem hiding this comment.
https://github.com/MetaMask/accounts/releases/tag/v12.0.0
@metamask/eth-simple-keyring 8.0.0
BREAKING: Add ESM build (MetaMask/accounts#40)
- It's no longer possible to import files from ./dist directly.
jeffsmale90
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract.
This change integrates the new
signEip7702Authorizationmethod added to eth- simple and hd keyrings in MetaMask/accounts#182. This is exposed viaKeyringController.signEip7702Authorizationas well as the message handlerKeyringController:SignEip7702Authorization.See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details