14.1.0 #329
Closed
14.1.0 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Gudahtt
reviewed
Sep 4, 2024
| ### Uncategorized | ||
| - Request validation should not throw if verifyingContract is not defined in typed signature ([#328](https://github.com/MetaMask/eth-json-rpc-middleware/pull/328)) | ||
| - Add changelog entries for `#318` ([#327](https://github.com/MetaMask/eth-json-rpc-middleware/pull/327)) | ||
| - remove eth_sign ([#320](https://github.com/MetaMask/eth-json-rpc-middleware/pull/320)) |
There was a problem hiding this comment.
This is a breaking change. Can we create a back port v14.0.1 release instead with just the bug fix? So that we can omit the breaking change and simplify the process of shipping this.
There was a problem hiding this comment.
I have created a 14.x branch that we can use as the target for a v14.0.1 RC.
Feel free to create the RC manually, it will need to be published manually anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 14.1.0.