Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramps): Adds a close button to the buy banner #28980

Merged
merged 25 commits into from
Feb 6, 2025

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Dec 6, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgeweiler georgeweiler requested a review from a team December 6, 2024 13:22
@georgeweiler georgeweiler changed the title feat(ramps): Adds a close button to the empty wallet card feat(ramps): Adds a close button to the buy banner Dec 6, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [e408ba8]
Page Load Metrics (2109 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19526811368869417
domContentLoaded161426302075253121
load163426842109249120
domInteractive24211654421
backgroundConnect11126413115
firstReactRender2188442010
getState45825199
initialActions024153
loadScripts121120421555219105
setupStore75920168
uiStartup185130442372290139
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 191 Bytes (0.00%)
  • ui: 870 Bytes (0.01%)
  • common: 69 Bytes (0.00%)

@georgeweiler georgeweiler marked this pull request as ready for review December 11, 2024 17:28
@georgeweiler georgeweiler requested a review from a team as a code owner December 11, 2024 17:28
@metamaskbot
Copy link
Collaborator

Builds ready [dc00941]
Page Load Metrics (1903 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26324331832417200
domContentLoaded156524231875220105
load158624331903234112
domInteractive26110462211
backgroundConnect998342914
firstReactRender1999543316
getState675282512
initialActions01000
loadScripts11671988142420196
setupStore78615209
uiStartup177527252247235113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 191 Bytes (0.00%)
  • ui: 870 Bytes (0.01%)
  • common: 69 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [1bbb9ed]
Page Load Metrics (1764 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23019531679351168
domContentLoaded14761931172911354
load15301946176411455
domInteractive227037147
backgroundConnect985352412
firstReactRender17120423014
getState65522199
initialActions01000
loadScripts1096149012968943
setupStore65318178
uiStartup175427542093249120

@wachunei
Copy link
Member

The concern I have is if we ever want to redisplay the card again in future (like for a promotion or announcemen) how would we do it. @Gudahtt have you experienced this case where the updated build overrides the user setting from a previous instance? would it be a migration?

Anyway, we would need to deliver that mechanism when that case happens. I'll approve.

@georgeweiler georgeweiler added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit a7b562d Feb 6, 2025
76 checks passed
@georgeweiler georgeweiler deleted the ramps-card-close-btn branch February 6, 2025 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-ramp
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants