test: Add basic tests for SnapUIRenderer #30099

FrederikBolding · 2025-02-04T13:30:07Z

Description

Establishes a base level of unit testing for the SnapUIRenderer including some snapshot and performance tests.

Related issues

Closes MetaMask/snaps#3060

metamaskbot · 2025-02-04T14:04:04Z

Builds ready [8ce28bc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1626 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	254	1900	1557	314	151
		domContentLoaded	1482	1875	1597	92	44
		load	1490	1900	1626	95	46
		domInteractive	23	73	47	19	9
		backgroundConnect	10	72	35	18	9
		firstReactRender	15	90	29	23	11
		getState	4	62	19	20	10
		initialActions	0	0	0	0	0
		loadScripts	1058	1407	1153	81	39
		setupStore	7	58	14	13	6
		uiStartup	1639	2306	1855	150	72

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-04T14:48:58Z

Builds ready [8193410]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1567 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1431	1796	1570	95	45
		domContentLoaded	1419	1778	1545	93	45
		load	1433	1799	1567	95	46
		domInteractive	22	93	38	24	11
		backgroundConnect	9	58	27	16	8
		firstReactRender	15	72	36	24	11
		getState	4	56	16	16	8
		initialActions	0	1	0	0	0
		loadScripts	1019	1340	1124	85	41
		setupStore	6	55	15	15	7
		uiStartup	1663	2024	1772	105	50

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-04T16:30:09Z

Builds ready [17f8f62]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1736 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1564	2055	1742	131	63
		domContentLoaded	1502	1976	1705	124	60
		load	1561	2052	1736	126	60
		domInteractive	17	109	42	23	11
		backgroundConnect	12	80	30	20	10
		firstReactRender	15	79	38	25	12
		getState	5	100	17	24	11
		initialActions	0	0	0	0	0
		loadScripts	1061	1431	1243	103	49
		setupStore	8	57	14	14	7
		uiStartup	1748	2518	1979	188	90

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-05T11:39:19Z

Builds ready [52c195d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1987 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	2272	1800	511	245
		domContentLoaded	1644	2261	1952	202	97
		load	1671	2317	1987	205	99
		domInteractive	26	121	47	24	11
		backgroundConnect	13	82	40	21	10
		firstReactRender	16	100	44	26	12
		getState	6	71	27	22	10
		initialActions	0	1	0	0	0
		loadScripts	1184	1694	1452	171	82
		setupStore	7	49	13	9	4
		uiStartup	1854	3078	2309	301	144

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-05T12:30:30Z

Builds ready [8d48d24]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1778 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1558	2161	1783	155	74
		domContentLoaded	1487	2082	1742	143	69
		load	1554	2170	1778	156	75
		domInteractive	16	81	36	14	7
		backgroundConnect	12	90	38	24	11
		firstReactRender	16	96	36	25	12
		getState	4	67	24	22	11
		initialActions	0	48	3	10	5
		loadScripts	1049	1592	1272	129	62
		setupStore	8	90	26	24	11
		uiStartup	1767	2662	2099	223	107

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 248 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-05T14:26:51Z

Builds ready [25fb3b2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1746 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1512	2189	1750	138	66
		domContentLoaded	1467	2164	1722	135	65
		load	1512	2197	1746	137	66
		domInteractive	23	189	50	40	19
		backgroundConnect	10	62	30	15	7
		firstReactRender	15	168	40	38	18
		getState	5	73	23	25	12
		initialActions	0	1	0	0	0
		loadScripts	1038	1625	1259	114	55
		setupStore	8	60	16	16	8
		uiStartup	1720	2515	2008	200	96

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 248 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-05T15:10:03Z

Builds ready [debbc76]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1725 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1542	1973	1721	124	60
		domContentLoaded	1528	1911	1696	117	56
		load	1544	1968	1725	124	60
		domInteractive	24	95	35	18	9
		backgroundConnect	10	76	31	20	9
		firstReactRender	16	92	40	26	13
		getState	5	84	18	22	11
		initialActions	0	1	0	0	0
		loadScripts	1064	1425	1225	103	50
		setupStore	8	62	15	14	7
		uiStartup	1804	2766	1995	212	102

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 213 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-07T11:36:29Z

Builds ready [305a552]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1777 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1576	2151	1782	156	75
		domContentLoaded	1569	2093	1754	148	71
		load	1574	2161	1777	153	74
		domInteractive	27	87	41	16	8
		backgroundConnect	9	72	23	20	10
		firstReactRender	16	177	49	39	19
		getState	5	67	23	23	11
		initialActions	0	1	0	0	0
		loadScripts	1104	1532	1272	118	57
		setupStore	8	80	17	20	10
		uiStartup	1863	2821	2112	243	117

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 213 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot added the team-snaps-platform Snaps Platform team label Feb 4, 2025

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 4, 2025

FrederikBolding force-pushed the fb/snap-ui-renderer-tests branch from 13fb039 to debbc76 Compare February 5, 2025 14:31

FrederikBolding added 12 commits February 7, 2025 11:56

test: Add basic tests for SnapUIRenderer

141685d

Fix lint

17ab173

Fix types

96ea098

Add more tests

51ae20e

Use any for now

d861fee

Add form submit test

49809c6

Add more re-render tests

71cad73

Add assertions and snapshots of re-renders

b76d98b

Fix lint

52cfd4b

Add field test

b23ae63

Update snapshot

3ed45d9

Add file input test

305a552

FrederikBolding force-pushed the fb/snap-ui-renderer-tests branch from 1406bd8 to 305a552 Compare February 7, 2025 10:56

FrederikBolding marked this pull request as ready for review February 7, 2025 10:56

FrederikBolding requested a review from a team as a code owner February 7, 2025 10:56

FrederikBolding enabled auto-merge February 7, 2025 10:58

Mrtenz approved these changes Feb 7, 2025

View reviewed changes

david0xd approved these changes Feb 7, 2025

View reviewed changes

FrederikBolding added this pull request to the merge queue Feb 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add basic tests for SnapUIRenderer #30099

test: Add basic tests for SnapUIRenderer #30099

FrederikBolding commented Feb 4, 2025 •

edited

Loading

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 7, 2025

test: Add basic tests for SnapUIRenderer #30099

Are you sure you want to change the base?

test: Add basic tests for SnapUIRenderer #30099

Conversation

FrederikBolding commented Feb 4, 2025 • edited Loading

Description

Related issues

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 7, 2025

FrederikBolding commented Feb 4, 2025 •

edited

Loading