Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore empty data field on hex data alert #30192

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Feb 7, 2025

Description

When the hex data field is enabled in the send flow, the data field is sent as 0x. In those cases we don't need to show the alert to the user.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 7, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 7, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner February 7, 2025 11:25
Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [3b462fe]
Page Load Metrics (1942 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15592178195015072
domContentLoaded15142112190614369
load15222192194215474
domInteractive26693695
backgroundConnect1091372612
firstReactRender1698372512
getState968252110
initialActions01000
loadScripts10951607140511655
setupStore88019209
uiStartup18092801226920096
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 69 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 36b58cd Feb 7, 2025
77 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/fix-non-contract-alerts branch February 7, 2025 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants