fix: Avoid nonce flicker when transaction is submitted

[pedronfigueiredo]

Description

Submitting or cancelling a transaction was clearing the custom nonce field before the confirmation popup had time to close. This PR fixes that.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4140

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

cancel.flicker.mov

nonce.goes.to.zero.on.transaction.mov

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [26c8bf0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1736 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	271	1947	1593	448	215
		domContentLoaded	1452	1921	1712	119	57
		load	1461	1943	1736	122	59
		domInteractive	25	180	41	34	16
		backgroundConnect	9	89	28	22	11
		firstReactRender	15	99	43	27	13
		getState	4	59	19	19	9
		initialActions	0	1	0	0	0
		loadScripts	1009	1466	1247	107	51
		setupStore	7	88	23	24	11
		uiStartup	1704	2497	2027	179	86

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -114 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[jpuri]

These calls were added here as it at times resulted in confirmation using old nonce when switching networks. Can you plz check if removing this does not re-introduce that bug.

[pedronfigueiredo]

After discussing this with @jpuri, she informed me that there used to be a bug in the legacy confirmations that:

• if you created confirmation on a network
• edit the nonce
• and then switch to another network
• the confirmation page now would show old nonce.

Thus we added this code to clear the old nonce value after confirmation was submitted.

I tested this scenario a few times and it seems to not be an issue in the new confirmations even when removing this code. I will ask our QA engineer to double check this for us.

[metamaskbot]

Builds ready [b991cd3]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1689 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1515	2493	1688	210	101
		domContentLoaded	1451	2425	1657	204	98
		load	1517	2512	1689	213	102
		domInteractive	20	113	35	22	11
		backgroundConnect	8	79	34	21	10
		firstReactRender	15	93	38	26	12
		getState	5	70	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	1010	1822	1209	170	82
		setupStore	7	56	20	18	9
		uiStartup	1728	2839	1932	258	124

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -114 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[sleepytanya]

No flickering in Chrome and Firefox:

Screen.Recording.2025-02-11.at.11.17.27.mov

Screen.Recording.2025-02-11.at.11.24.47.mov