Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide network fee fiat conversion on test nets #30196

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Feb 7, 2025

Description

This PR introduces a missing parenthesis in the display logic.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4147

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 7, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 7, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner February 7, 2025 11:45
Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri
jpuri previously approved these changes Feb 7, 2025
OGPoyraz
OGPoyraz previously approved these changes Feb 7, 2025
@pedronfigueiredo pedronfigueiredo dismissed stale reviews from OGPoyraz and jpuri via b7fa514 February 7, 2025 19:04
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/4147 branch 7 times, most recently from f4e0cbd to 1b58747 Compare February 11, 2025 18:09
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 12, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [afa28a5]
Page Load Metrics (1754 ± 156 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38122531568457220
domContentLoaded143026811727329158
load143426921754325156
domInteractive216939178
backgroundConnect8224334622
firstReactRender1476382411
getState46213168
initialActions01000
loadScripts102120281253253121
setupStore75614147
uiStartup160230471985372178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 6 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit f750ec5 Feb 12, 2025
73 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/4147 branch February 12, 2025 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants