Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add advanced details tooltip #30197

Merged
merged 1 commit into from
Feb 11, 2025
Merged

feat: Add advanced details tooltip #30197

merged 1 commit into from
Feb 11, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Feb 7, 2025

Description

Adds tooltip to inform the user.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3785

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2025-02-07 at 11 54 09
Screenshot 2025-02-07 at 11 54 01

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 7, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 7, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner February 7, 2025 12:02
Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri
jpuri previously approved these changes Feb 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3ac7bc7]
Page Load Metrics (1485 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1350177014939646
domContentLoaded1338169614678239
load1347177114859445
domInteractive228236199
backgroundConnect77924209
firstReactRender1593352512
getState44510105
initialActions00000
loadScripts929128210438239
setupStore711810
uiStartup15132146169914469
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 415 Bytes (0.01%)
  • common: 108 Bytes (0.00%)

OGPoyraz
OGPoyraz previously approved these changes Feb 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [971841c]
Page Load Metrics (1740 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42122171673325156
domContentLoaded15142198171215373
load15322223174015574
domInteractive24140523417
backgroundConnect10100352211
firstReactRender1779362412
getState461232010
initialActions01000
loadScripts10551646123313665
setupStore66115157
uiStartup17232492198616680
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 415 Bytes (0.01%)
  • common: 108 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 245d96f Feb 11, 2025
72 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3785 branch February 11, 2025 12:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants