Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix e2e decimal #30203

Merged
merged 4 commits into from
Feb 7, 2025
Merged

fix: fix e2e decimal #30203

merged 4 commits into from
Feb 7, 2025

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Feb 7, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri requested a review from seaona February 7, 2025 14:37
@sahar-fehri sahar-fehri marked this pull request as ready for review February 7, 2025 14:44
Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏

@sahar-fehri sahar-fehri enabled auto-merge February 7, 2025 14:51
@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [eb0c9f7]
Page Load Metrics (1677 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint140323461680265127
domContentLoaded138622641657259124
load140622701677261125
domInteractive237741199
backgroundConnect96023167
firstReactRender146322126
getState469222311
initialActions01000
loadScripts9861655120120699
setupStore794242512
uiStartup156327091914313150
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit e63ca9a Feb 7, 2025
72 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-decimals branch February 7, 2025 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants