chore: update accounts deps + some related peer deps #30205

ccharly · 2025-02-07T14:49:36Z

Description

Updating the accounts-controler and some other peer dependencies.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-07T14:49:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-02-07T14:51:04Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	281 kB	danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`+1`	346 kB	danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`+1`	488 kB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	535 kB	danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	35.7 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	66.2 kB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	2.18 MB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	490 kB	metamaskbot

View full report↗︎

ccharly · 2025-02-07T15:49:41Z

@metamaskbot update-policies

metamaskbot · 2025-02-07T16:02:22Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-02-07T17:13:01Z

Builds ready [0e6799f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1751 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1494	2251	1760	186	89
		domContentLoaded	1483	2168	1719	175	84
		load	1496	2241	1751	189	91
		domInteractive	19	101	37	23	11
		backgroundConnect	12	100	29	20	10
		firstReactRender	14	95	47	28	13
		getState	5	62	19	20	10
		initialActions	0	1	0	0	0
		loadScripts	1083	1605	1258	140	67
		setupStore	7	88	16	19	9
		uiStartup	1700	2678	1999	254	122

Bundle size diffs [🚀 Bundle size reduced!]

background: 11.1 KiB (0.19%)
ui: 0 Bytes (0.00%)
common: -33.51 KiB (-0.36%)

ccharly · 2025-02-11T09:41:49Z

lavamoat/browserify/beta/policy.json

@@ -913,7 +918,7 @@
        "@metamask/contract-metadata": true,
        "@metamask/controller-utils": true,
        "@metamask/controller-utils>@metamask/eth-query": true,
-        "@metamask/assets-controllers>@metamask/keyring-api": true,


Now aligned with the latest keyring-api, so this rule is no longer needed.

ccharly · 2025-02-11T09:41:55Z

lavamoat/browserify/beta/policy.json

-    "@metamask/assets-controllers>@metamask/keyring-api": {
-      "packages": {
-        "@metamask/keyring-api>@metamask/keyring-utils": true,
-        "@metamask/utils>@metamask/superstruct": true,
-        "@metamask/assets-controllers>@metamask/utils": true,
-        "@metamask/keyring-api>bech32": true
-      }
-    },


zone-live · 2025-02-11T10:20:33Z

@metamaskbot update-policies

metamaskbot · 2025-02-11T10:29:12Z

Policy update failed. You can review the logs or retry the policy update here

metamaskbot · 2025-02-11T11:16:53Z

Builds ready [4d03671]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1826 ± 110 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	391	2241	1592	518	249
		domContentLoaded	1503	2230	1802	225	108
		load	1523	2278	1826	230	110
		domInteractive	22	115	41	22	11
		backgroundConnect	10	63	30	17	8
		firstReactRender	15	85	39	26	13
		getState	5	67	18	20	9
		initialActions	0	1	0	0	0
		loadScripts	1071	1690	1323	189	91
		setupStore	8	56	17	15	7
		uiStartup	1781	2591	2120	244	117

Bundle size diffs [🚀 Bundle size reduced!]

background: 11.17 KiB (0.19%)
ui: 0 Bytes (0.00%)
common: -33.51 KiB (-0.36%)

ccharly added the team-accounts label Feb 7, 2025

ccharly self-assigned this Feb 7, 2025

ccharly linked an issue Feb 7, 2025 that may be closed by this pull request

Update metamask/accounts-controller to version 23.0.0 #30153

Closed

chore: update accounts deps

bb95292

ccharly force-pushed the chore/update-accounts-deps branch from 7aacacd to bb95292 Compare February 7, 2025 14:53

ccharly added 3 commits February 7, 2025 16:53

fix: add missing event for the MultichainTransactionController

7861ddd

chore: dedupe

953e015

chore: lavamoat:auto

7233d66

ccharly force-pushed the chore/update-accounts-deps branch from d7c439a to 7233d66 Compare February 7, 2025 15:58

Update LavaMoat policies

8e85dc5

ccharly added 2 commits February 7, 2025 17:35

chore: remove Multichain{Balances,Transactions}Controller old actions

caff6ff

chore: lavamoat:auto

0e6799f

ccharly commented Feb 11, 2025

View reviewed changes

ccharly marked this pull request as ready for review February 11, 2025 09:42

ccharly requested review from a team as code owners February 11, 2025 09:42

ccharly mentioned this pull request Feb 11, 2025

chore: bump controller version #30209

Merged

7 tasks

ccharly changed the title ~~chore: update accounts deps~~ chore: update accounts deps + some related peer deps Feb 11, 2025

This was linked to issues Feb 11, 2025

Update metamask/transaction-controller to version 45.0.0 #30156

Closed

Update metamask/user-operation-controller to version 24.0.0 #30157

Closed

Merge branch 'main' into chore/update-accounts-deps

fce6f96

chore: fix lavamoat policies

4d03671

zone-live approved these changes Feb 11, 2025

View reviewed changes

danroc approved these changes Feb 11, 2025

View reviewed changes

danroc enabled auto-merge February 11, 2025 11:06

danroc added this pull request to the merge queue Feb 11, 2025

ccharly mentioned this pull request Feb 11, 2025

refactor(snap-keyring): refactor Snap keyring implementation #30244

Open

8 tasks

montelaidev approved these changes Feb 11, 2025

View reviewed changes

Merged via the queue into main with commit c5a6560 Feb 11, 2025
72 checks passed

danroc deleted the chore/update-accounts-deps branch February 11, 2025 12:24

github-actions bot locked and limited conversation to collaborators Feb 11, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update accounts deps + some related peer deps #30205

chore: update accounts deps + some related peer deps #30205

ccharly commented Feb 7, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Feb 7, 2025

socket-security bot commented Feb 7, 2025 •

edited

Loading

ccharly commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

ccharly Feb 11, 2025

ccharly Feb 11, 2025

zone-live commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

chore: update accounts deps + some related peer deps #30205

chore: update accounts deps + some related peer deps #30205

Conversation

ccharly commented Feb 7, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 7, 2025

socket-security bot commented Feb 7, 2025 • edited Loading

ccharly commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

ccharly Feb 11, 2025

Choose a reason for hiding this comment

ccharly Feb 11, 2025

Choose a reason for hiding this comment

zone-live commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

ccharly commented Feb 7, 2025 •

edited by github-actions bot

Loading

socket-security bot commented Feb 7, 2025 •

edited

Loading