Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show max network fee tooltip #30208

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Feb 7, 2025

Description

Open in GitHub Codespaces

This PR moves the max fee for a bridge tx into a tooltip.

Related issues

Fixes:

Manual testing steps

  1. Go to bridge
  2. Enter in your from and to tokens and amounts
  3. See network fee
  4. Hover over it for the max

Screenshots/Recordings

Before

After

Screenshot 2025-02-07 at 10 47 48 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower changed the title chore: remove max network fee display chore: show max network fee tooltip Feb 7, 2025
@infiniteflower infiniteflower marked this pull request as ready for review February 7, 2025 15:42
@infiniteflower infiniteflower requested a review from a team as a code owner February 7, 2025 15:42
@metamaskbot
Copy link
Collaborator

Builds ready [36e85b3]
Page Load Metrics (1567 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14202234157217483
domContentLoaded14132223155117483
load14212235156717383
domInteractive19104542412
backgroundConnect8351894
firstReactRender1471282010
getState45411136
initialActions01000
loadScripts10041715113115675
setupStore75617199
uiStartup15772544176319996
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -18 Bytes (-0.00%)
  • common: -110 Bytes (-0.00%)

ghgoodreau
ghgoodreau previously approved these changes Feb 7, 2025
micaelae
micaelae previously approved these changes Feb 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2be76bc]
Page Load Metrics (1846 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24326071666532255
domContentLoaded150925301812251120
load151826071846260125
domInteractive2584442010
backgroundConnect1195342512
firstReactRender1797412713
getState56415147
initialActions01000
loadScripts10531896130520196
setupStore892262512
uiStartup179429202153320153
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 75 Bytes (0.00%)

@infiniteflower infiniteflower added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@infiniteflower infiniteflower added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 0eb7d57 Feb 11, 2025
72 checks passed
@infiniteflower infiniteflower deleted the fix/mms-1901-remove-max-gas branch February 11, 2025 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants