feat: disable metametrics when disabling basic functionality #30210

mathieuartu · 2025-02-07T16:10:02Z

Description

This PR disables MetaMetrics when turning basic functionality off.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/IDENTITY-18

Manual testing steps

Create a new wallet
Disable basic functionality in the onboarding settings
Finish creating your wallet
Go to the privacy settings and verify that both MetaMetrics are off and disabled
Turn basic functionality back on
Enable MetaMetrics and marketing collection
Disable basic functionality
Verify that both MetaMetrics toggles are off and disabled
Enable basic functionality
Verify that both MetaMetrics toggles are not disabled but still off

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-07T16:10:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-07T16:44:50Z

Builds ready [c51c1f4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1889 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	606	2213	1819	330	158
		domContentLoaded	1526	2148	1854	176	85
		load	1540	2182	1889	176	84
		domInteractive	23	103	43	23	11
		backgroundConnect	10	71	36	21	10
		firstReactRender	15	103	47	32	15
		getState	8	95	32	27	13
		initialActions	0	1	0	0	0
		loadScripts	1101	1594	1357	144	69
		setupStore	6	55	13	10	5
		uiStartup	1804	2800	2261	236	113

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 84 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-11T19:23:52Z

Builds ready [9facebe]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1583 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	494	1922	1524	257	124
		domContentLoaded	1450	1910	1560	108	52
		load	1467	1922	1583	106	51
		domInteractive	22	85	34	17	8
		backgroundConnect	9	57	22	15	7
		firstReactRender	15	70	38	23	11
		getState	4	55	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	999	1432	1137	96	46
		setupStore	7	68	12	13	6
		uiStartup	1664	2243	1802	130	62

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 84 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-12T11:58:28Z

Builds ready [583af04]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1656 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1449	1950	1659	138	66
		domContentLoaded	1433	1944	1632	139	67
		load	1447	1951	1656	142	68
		domInteractive	24	104	42	22	11
		backgroundConnect	9	66	27	20	10
		firstReactRender	15	82	33	24	12
		getState	5	53	15	16	8
		initialActions	0	1	0	0	0
		loadScripts	1016	1465	1191	115	55
		setupStore	6	70	12	13	6
		uiStartup	1652	2233	1912	174	83

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 84 Bytes (0.00%)
common: 0 Bytes (0.00%)

cmd-ob

Tested the build and this is working as expected.

metamaskbot · 2025-02-12T15:14:52Z

Builds ready [4856fc2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1542 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1331	1776	1551	113	54
		domContentLoaded	1323	1724	1519	100	48
		load	1332	1780	1542	106	51
		domInteractive	23	93	38	21	10
		backgroundConnect	10	65	28	17	8
		firstReactRender	14	93	33	26	12
		getState	4	55	14	16	8
		initialActions	0	1	0	0	0
		loadScripts	917	1287	1092	91	44
		setupStore	7	53	13	13	6
		uiStartup	1480	2357	1797	198	95

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 206 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-12T20:28:17Z

Builds ready [db17693]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1587 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1435	1919	1592	122	59
		domContentLoaded	1420	1847	1561	110	53
		load	1428	1918	1587	124	59
		domInteractive	21	78	30	12	6
		backgroundConnect	8	99	26	23	11
		firstReactRender	15	91	40	27	13
		getState	4	84	13	19	9
		initialActions	0	1	0	0	0
		loadScripts	1001	1399	1132	103	49
		setupStore	7	54	13	14	7
		uiStartup	1677	2333	1852	177	85

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 253 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-12T21:51:36Z

Builds ready [9b4a491]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1566 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	300	1809	1436	382	184
		domContentLoaded	1362	1787	1542	130	62
		load	1373	1813	1566	135	65
		domInteractive	22	160	47	35	17
		backgroundConnect	8	72	22	18	9
		firstReactRender	15	64	29	19	9
		getState	4	55	19	19	9
		initialActions	0	1	0	0	0
		loadScripts	948	1325	1120	109	52
		setupStore	6	59	13	14	7
		uiStartup	1547	2039	1772	148	71

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 253 Bytes (0.00%)
common: 0 Bytes (0.00%)

feat: disable metametrics when disabling basic functionality

c51c1f4

mathieuartu added the team-identity label Feb 7, 2025

mathieuartu self-assigned this Feb 7, 2025

Merge branch 'main' into feat/disable-metametrics-basic-functionality

9facebe

Merge branch 'main' into feat/disable-metametrics-basic-functionality

583af04

mathieuartu added 2 commits February 12, 2025 15:34

feat: add UTs and more robust logic handling

557c96f

Merge branch 'main' into feat/disable-metametrics-basic-functionality

4856fc2

mathieuartu marked this pull request as ready for review February 12, 2025 14:39

cmd-ob enabled auto-merge February 12, 2025 14:58

cmd-ob disabled auto-merge February 12, 2025 14:58

cmd-ob previously approved these changes Feb 12, 2025

View reviewed changes

dovydas55 previously approved these changes Feb 12, 2025

View reviewed changes

mathieuartu added this pull request to the merge queue Feb 12, 2025

mathieuartu removed this pull request from the merge queue due to a manual request Feb 12, 2025

feat: disable metametrics toggles when BF is off

72f309d

mathieuartu dismissed stale reviews from dovydas55 and cmd-ob via 72f309d February 12, 2025 19:02

mathieuartu added 3 commits February 12, 2025 20:03

Merge branch 'main' into feat/disable-metametrics-basic-functionality

84a119e

Merge branch 'main' into feat/disable-metametrics-basic-functionality

1efd8a5

fix: e2e test

db17693

mathieuartu added 2 commits February 12, 2025 21:52

fix: unit test

5de2448

Merge branch 'main' into feat/disable-metametrics-basic-functionality

9b4a491

cmd-ob approved these changes Feb 13, 2025

View reviewed changes

mathieuartu enabled auto-merge February 13, 2025 10:51

dovydas55 approved these changes Feb 13, 2025

View reviewed changes

mathieuartu added this pull request to the merge queue Feb 13, 2025

Merged via the queue into main with commit 901ce6a Feb 13, 2025
73 checks passed

mathieuartu deleted the feat/disable-metametrics-basic-functionality branch February 13, 2025 11:27

github-actions bot locked and limited conversation to collaborators Feb 13, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: disable metametrics when disabling basic functionality #30210

feat: disable metametrics when disabling basic functionality #30210

mathieuartu commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 12, 2025

cmd-ob left a comment

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

feat: disable metametrics when disabling basic functionality #30210

feat: disable metametrics when disabling basic functionality #30210

Conversation

mathieuartu commented Feb 7, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 12, 2025

cmd-ob left a comment

Choose a reason for hiding this comment

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

mathieuartu commented Feb 7, 2025 •

edited

Loading